netdev - Re: [PATCH v5 04/14] scsi: megaraid_sas: Use irq_set_affinity_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL2rwxqz4dcjdbqtPMaCTud+3jPhuFvJeuVgt774Rpm-+_KJxQ@mail.gmail.com>
Date:   Fri, 6 Aug 2021 17:01:17 +0530
From:   Sumit Saxena <sumit.saxena@...adcom.com>
To:     Nitesh Narayan Lal <nitesh@...hat.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Linux SCSI List <linux-scsi@...r.kernel.org>,
        intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        linux-api@...r.kernel.org, linux-pci@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        jesse.brandeburg@...el.com, robin.murphy@....com,
        mtosatti@...hat.com, mingo@...nel.org, jbrandeb@...nel.org,
        frederic@...nel.org, juri.lelli@...hat.com, abelits@...vell.com,
        Bjorn Helgaas <bhelgaas@...gle.com>, rostedt@...dmis.org,
        peterz@...radead.org, "David S. Miller" <davem@...emloft.net>,
        akpm@...ux-foundation.org, sfr@...b.auug.org.au,
        stephen@...workplumber.org, rppt@...ux.vnet.ibm.com,
        chris.friesen@...driver.com, maz@...nel.org, nhorman@...driver.com,
        pjwaskiewicz@...il.com, sassmann@...hat.com,
        Tomas Henzl <thenzl@...hat.com>,
        Kashyap Desai <kashyap.desai@...adcom.com>,
        Shivasharan Srikanteshwara 
        <shivasharan.srikanteshwara@...adcom.com>,
        Sathya Prakash Veerichetty <sathya.prakash@...adcom.com>,
        Sreekanth Reddy <sreekanth.reddy@...adcom.com>,
        Suganath Prabu Subramani 
        <suganath-prabu.subramani@...adcom.com>, james.smart@...adcom.com,
        dick.kennedy@...adcom.com, jkc@...hat.com, faisal.latif@...el.com,
        shiraz.saleem@...el.com, tariqt@...dia.com, ahleihel@...hat.com,
        kheib@...hat.com, borisp@...dia.com, saeedm@...dia.com,
        benve@...co.com, govind@....com, jassisinghbrar@...il.com,
        ajit.khaparde@...adcom.com, sriharsha.basavapatna@...adcom.com,
        Somnath Kotur <somnath.kotur@...adcom.com>,
        Nitesh Lal <nilal@...hat.com>, tatyana.e.nikolova@...el.com,
        mustafa.ismail@...el.com, ahs3@...hat.com, leonro@...dia.com,
        Chandrakanth Patil <chandrakanth.patil@...adcom.com>,
        bjorn.andersson@...aro.org, chunkuang.hu@...nel.org,
        yongqiang.niu@...iatek.com, baolin.wang7@...il.com,
        poros@...hat.com, minlei@...hat.com,
        Ewan Milne <emilne@...hat.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>, _govind@....com,
        kabel@...nel.org, viresh.kumar@...aro.org,
        Tushar.Khandelwal@....com, kuba@...nel.org
Subject: Re: [PATCH v5 04/14] scsi: megaraid_sas: Use irq_set_affinity_and_hint

On Wed, Jul 21, 2021 at 4:57 AM Nitesh Narayan Lal <nitesh@...hat.com> wrote:
>
> The driver uses irq_set_affinity_hint() specifically for the high IOPS
> queue interrupts for two purposes:
>
> - To set the affinity_hint which is consumed by the userspace for
>   distributing the interrupts
>
> - To apply an affinity that it provides
>
> The driver enforces its own affinity to bind the high IOPS queue interrupts
> to the local NUMA node. However, irq_set_affinity_hint() applying the
> provided cpumask as an affinity for the interrupt is an undocumented side
> effect.
>
> To remove this side effect irq_set_affinity_hint() has been marked
> as deprecated and new interfaces have been introduced. Hence, replace the
> irq_set_affinity_hint() with the new interface irq_set_affinity_and_hint()
> where the provided mask needs to be applied as the affinity and
> affinity_hint pointer needs to be set and replace with
> irq_update_affinity_hint() where only affinity_hint needs to be updated.
>
> Change the megasas_set_high_iops_queue_affinity_hint function name to
> megasas_set_high_iops_queue_affinity_and_hint to clearly indicate that the
> function is setting both affinity and affinity_hint.
>
> Signed-off-by: Nitesh Narayan Lal <nitesh@...hat.com>
Looks good.
Acked-by: Sumit Saxena <sumit.saxena@...adcom.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)