netdev - Re: [PATCH v3 bpf-next 1/2] bpf: af_unix: Implement BPF iterator for UNIX domain socket.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210806002156.12075-1-kuniyu@amazon.co.jp>
Date:   Fri, 6 Aug 2021 09:21:56 +0900
From:   Kuniyuki Iwashima <kuniyu@...zon.co.jp>
To:     <yhs@...com>
CC:     <andrii@...nel.org>, <ast@...nel.org>, <benh@...zon.com>,
        <bpf@...r.kernel.org>, <daniel@...earbox.net>,
        <davem@...emloft.net>, <john.fastabend@...il.com>, <kafai@...com>,
        <kpsingh@...nel.org>, <kuba@...nel.org>, <kuni1840@...il.com>,
        <kuniyu@...zon.co.jp>, <netdev@...r.kernel.org>,
        <songliubraving@...com>
Subject: Re: [PATCH v3 bpf-next 1/2] bpf: af_unix: Implement BPF iterator for UNIX domain socket.

From:   Yonghong Song <yhs@...com>
Date:   Thu, 5 Aug 2021 09:53:40 -0700
> On 8/4/21 12:08 AM, Kuniyuki Iwashima wrote:
> > This patch implements the BPF iterator for the UNIX domain socket and
> > exports some functions under GPL for the CONFIG_UNIX=m case.
> > 
> > Currently, the batch optimization introduced for the TCP iterator in the
> > commit 04c7820b776f ("bpf: tcp: Bpf iter batching and lock_sock") is not
> > applied.  It will require replacing the big lock for the hash table with
> > small locks for each hash list not to block other processes.
> > 
> > Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.co.jp>
> > ---
> >   fs/proc/proc_net.c      |  2 +
> >   include/linux/btf_ids.h |  3 +-
> >   kernel/bpf/bpf_iter.c   |  3 ++
> >   net/core/filter.c       |  1 +
> >   net/unix/af_unix.c      | 93 +++++++++++++++++++++++++++++++++++++++++
> >   5 files changed, 101 insertions(+), 1 deletion(-)
> > 
> > diff --git a/fs/proc/proc_net.c b/fs/proc/proc_net.c
> > index 15c2e55d2ed2..887a8102da9f 100644
> > --- a/fs/proc/proc_net.c
> > +++ b/fs/proc/proc_net.c
> > @@ -91,6 +91,7 @@ int bpf_iter_init_seq_net(void *priv_data, struct bpf_iter_aux_info *aux)
> >   #endif
> >   	return 0;
> >   }
> > +EXPORT_SYMBOL_GPL(bpf_iter_init_seq_net);
> 
> bpf_iter does not support modules for now as it is implemented before 
> module btf support. It needs some changes.
> For example, currently bpf_iter only caches/uses the vmlinux btf_id
> and module obj_id and module btf_id is not used.
> One example is ipv6 and bpf_iter is guarded with IS_BUILTIN(CONFIG_IPV6).
> 
> So you could (1) add btf_iter support module btf in this patch set, or
> (2). check IS_BUILTIN(CONFIG_UNIX). (2) might be easier and you can have
> a subsequent patch set to add module support for bpf_iter. But it is
> up to you.

I'll add IS_BUILTIN() check in the next spin and give a try to (1).
Thanks for review!