netdev - Re: [PATCH 1/1] can: esd: add support for esd GmbH PCIe/402 CAN interface family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e71fb47c9ecb3dce683b69b1d25b873e18b5da7d.camel@esd.eu>
Date:   Fri, 6 Aug 2021 15:03:00 +0000
From:   Stefan Mätje <Stefan.Maetje@....eu>
To:     "lkp@...el.com" <lkp@...el.com>
CC:     "kbuild-all@...ts.01.org" <kbuild-all@...ts.01.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
        "wg@...ndegger.com" <wg@...ndegger.com>,
        "mkl@...gutronix.de" <mkl@...gutronix.de>
Subject: Re: [PATCH 1/1] can: esd: add support for esd GmbH PCIe/402 CAN
 interface family

Am Freitag, den 30.07.2021, 14:33 +0800 schrieb kernel test robot:
> Hi "Stefan,
> 
> Thank you for the patch! Yet something to improve:
> 
> [auto build test ERROR on 8dad5561c13ade87238d9de6dd410b43f7562447]
> 
> url:    
> https://github.com/0day-ci/linux/commits/Stefan-M-tje/can-esd-add-support-for-esd-GmbH-PCIe-402-CAN-interface-family/20210729-044114
> base:   8dad5561c13ade87238d9de6dd410b43f7562447
> config: i386-randconfig-a004-20210728 (attached as .config)
> compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
> reproduce (this is a W=1 build):
>         # 
> https://github.com/0day-ci/linux/commit/5110edee0d2180efeaa1236b2652709848bdd6fc
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review Stefan-M-tje/can-esd-add-support-for-
> esd-GmbH-PCIe-402-CAN-interface-family/20210729-044114
>         git checkout 5110edee0d2180efeaa1236b2652709848bdd6fc
>         # save the attached .config to linux build tree
>         make W=1 ARCH=i386 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>, old ones prefixed by <<):
> 
> > > ERROR: modpost: "register_candev" [drivers/net/can/esd/esd_402_pci.ko]
> > > undefined!
> > > ERROR: modpost: "alloc_can_err_skb" [drivers/net/can/esd/esd_402_pci.ko]
> > > undefined!
> > > ERROR: modpost: "can_bus_off" [drivers/net/can/esd/esd_402_pci.ko]
> > > undefined!
> > > ERROR: modpost: "close_candev" [drivers/net/can/esd/esd_402_pci.ko]
> > > undefined!
> > > ERROR: modpost: "alloc_candev_mqs" [drivers/net/can/esd/esd_402_pci.ko]
> > > undefined!
> ERROR: modpost: "free_candev" [drivers/net/can/esd/esd_402_pci.ko] undefined!
> ERROR: modpost: "can_change_mtu" [drivers/net/can/esd/esd_402_pci.ko]
> undefined!
> ERROR: modpost: "can_change_state" [drivers/net/can/esd/esd_402_pci.ko]
> undefined!
> ERROR: modpost: "unregister_candev" [drivers/net/can/esd/esd_402_pci.ko]
> undefined!
> ERROR: modpost: "alloc_can_skb" [drivers/net/can/esd/esd_402_pci.ko]
> undefined!
> WARNING: modpost: suppressed 4 unresolved symbol warnings because there were
> too many)

Fixed
by v2 of this patch see:
https://lore.kernel.org/linux-can/20210730173805.3926-2-Stefan.Maetje@esd.eu/

The module was compiled unconditionally. This was a leftover from when the
module was built outside the kernel.

Best regards,
Stefan

-- 
System Design

Phone: +49-511-37298-146
E-Mail: stefan.maetje@....eu
_______________________________________
esd electronics gmbh
Vahrenwalder Str. 207
30165 Hannover
www.esd.eu

Quality Products – Made in Germany
_______________________________________

Register Hannover HRB 51373 - VAT-ID DE 115672832
General Manager: Klaus Detering