netdev - Re: [PATCH v2] once: Fix panic when module unload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <7ae60193-0114-46d2-9770-697a2f88b85b@www.fastmail.com>
Date:   Fri, 06 Aug 2021 17:22:55 +0200
From:   "Hannes Frederic Sowa" <hannes@...essinduktion.org>
To:     "Kefeng Wang" <wangkefeng.wang@...wei.com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        "David Miller" <davem@...emloft.net>
Cc:     "Andrew Morton" <akpm@...ux-foundation.org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Daniel Borkmann" <daniel@...earbox.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        "Minmin chen" <chenmingmin@...wei.com>
Subject: Re: [PATCH v2] once: Fix panic when module unload

On Fri, Aug 6, 2021, at 10:21, Kefeng Wang wrote:
> DO_ONCE
> DEFINE_STATIC_KEY_TRUE(___once_key);
> __do_once_done
>   once_disable_jump(once_key);
>     INIT_WORK(&w->work, once_deferred);
>     struct once_work *w;
>     w->key = key;
>     schedule_work(&w->work);                     module unload
>                                                    //*the key is
> destroy*
> process_one_work
>   once_deferred
>     BUG_ON(!static_key_enabled(work->key));
>        static_key_count((struct static_key *)x)    //*access key, crash*
> 
> When module uses DO_ONCE mechanism, it could crash due to the above
> concurrency problem, we could reproduce it with link[1].
> 
> Fix it by add/put module refcount in the once work process.
> 
> [1] 
> https://lore.kernel.org/netdev/eaa6c371-465e-57eb-6be9-f4b16b9d7cbf@huawei.com/
> 
> Cc: Hannes Frederic Sowa <hannes@...essinduktion.org>
> Cc: Daniel Borkmann <daniel@...earbox.net>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Minmin chen <chenmingmin@...wei.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>

Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Thanks,
Hannes