netdev - Re: RMNET QMAP data aggregation with size greater than 16384

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAP7ucLDFPMG08syrcnKKrX-+MS4_-tpPzZSfMOD6_7G-zq4gQ@mail.gmail.com>
Date:   Fri, 6 Aug 2021 22:22:02 +0200
From:   Aleksander Morgado <aleksander@...ksander.es>
To:     Bjørn Mork <bjorn@...k.no>
Cc:     Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>,
        Daniele Palmas <dnlplm@...il.com>,
        Network Development <netdev@...r.kernel.org>,
        Sean Tranchetti <stranche@...eaurora.org>
Subject: Re: RMNET QMAP data aggregation with size greater than 16384

Hey,

> > The summary of the thread was to set a large rx_urb_size during probe
> > itself for qmi_wwan.
>
> Yes, I think it would be good to make the driver DTRT automatically.
> Coding driver specific quirks into ModemManager might work, but it feels
> wrong to work around a Linux driver bug. We don't have to do that.  We
> can fix the driver.
>
> > https://patchwork.kernel.org/project/linux-usb/patch/20200803065105.8997-1-yzc666@netease.com/
> >
> > We could try setting a large value as suggested there and it should
> > hopefully
> > solve the issue you are seeing.
>
> Why can't we break the rx_urb_size dependency on MTU automatically when
> pass_through or qmi_wwan internal muxing is enabled? Preferably with
> some fixed default size which would Just Work for everyone.
>

That default fixed size you're suggesting for the rx_urb_size, isn't
it supposed to have the same logical meaning as RMNET_MAX_PACKET_SIZE
at the end?

-- 
Aleksander
https://aleksander.es