netdev - Re: [PATCH net-next 1/2] selftests/net: GRO coalesce test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <dea381f16949a076860a550ae1db91dcca935f8f.camel@redhat.com>
Date:   Fri, 06 Aug 2021 09:49:53 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Coco Li <lixiaoyan@...gle.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        Willem de Bruijn <willemb@...gle.com>,
        Tanner Love <tannerlove@...gle.com>
Subject: Re: [PATCH net-next 1/2] selftests/net: GRO coalesce test

Hello,

On Thu, 2021-08-05 at 13:17 -0700, Coco Li wrote:
> > Have you considered additionally run the same test of top of a veth
> > pair, and have such tests always enabled, so we could have some
> > coverage regardless of specific H/W available?
> 
> > To do the above you should disable TSO on the veth sender peer and
> > enable GRO on the other end.
> 
> Thanks for the suggestion! To make sure I understand you correctly,
> would this be another script that creates the veth pair separate from
> the gro.sh wrapper?

I personally don't have any strict preference. I *think* the veth
thing could still fit the gro.sh script, but whatever is easier coding
wise would fit. 

The gro.sh script with no/default argument could run all the tests on a
veth pair; if a device name is specified via the command line, it could
additionally run (the specified set of tests) on such device.

Cheers,

Paolo