netdev - Re: [PATCH] parisc: Make struct parisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210807091135.xgenctifq3wgn3ro@pengutronix.de>
Date:   Sat, 7 Aug 2021 11:11:35 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Corey Minyard <minyard@....org>
Cc:     kernel@...gutronix.de, alsa-devel@...a-project.org,
        linux-parisc@...r.kernel.org,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Helge Deller <deller@....de>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-scsi@...r.kernel.org, Takashi Iwai <tiwai@...e.com>,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
        netdev@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-input@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
        openipmi-developer@...ts.sourceforge.net,
        Jaroslav Kysela <perex@...ex.cz>,
        Jiri Slaby <jirislaby@...nel.org>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] parisc: Make struct parisc_driver::remove() return void

Hello,

On Fri, Aug 06, 2021 at 12:49:27PM -0500, Corey Minyard wrote:
> On Fri, Aug 06, 2021 at 11:39:38AM +0200, Uwe Kleine-König wrote:
> > -int ipmi_si_remove_by_dev(struct device *dev)
> > +void ipmi_si_remove_by_dev(struct device *dev)
> 
> This function is also used by ipmi_si_platform.c, so you can't change
> this.

Did you see that I adapted ipmi_si_platform.c below? That is an instance
of "Make [ipmi_si_remove_by_dev] return void, too, as for all other
callers the value is ignored, too." (In ipmi_si_platform.c the return
value is used in a struct platform_driver::remove function. The value
returned there is ignored, see commit
e5e1c209788138f33ca6558bf9f572f6904f486d.)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)