netdev - Re: [PATCH v2] parisc: Make struct parisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 7 Aug 2021 12:59:50 +0100
From:   Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
        Helge Deller <deller@....de>,
        Sascha Hauer <kernel@...gutronix.de>,
        alsa-devel@...a-project.org, Corey Minyard <minyard@....org>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Takashi Iwai <tiwai@...e.com>, linux-scsi@...r.kernel.org,
        netdev <netdev@...r.kernel.org>,
        linux-parisc <linux-parisc@...r.kernel.org>,
        linux-serial@...r.kernel.org, linux-input@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>,
        openipmi-developer@...ts.sourceforge.net,
        Jaroslav Kysela <perex@...ex.cz>,
        Jiri Slaby <jirislaby@...nel.org>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH v2] parisc: Make struct parisc_driver::remove() return void

On Sat, Aug 7, 2021 at 10:19 AM Uwe Kleine-König
<u.kleine-koenig@...gutronix.de> wrote:
>
> The caller of this function (parisc_driver_remove() in
> arch/parisc/kernel/drivers.c) ignores the return value, so better don't
> return any value at all to not wake wrong expectations in driver authors.
>
> The only function that could return a non-zero value before was
> ipmi_parisc_remove() which returns the return value of
> ipmi_si_remove_by_dev(). Make this function return void, too, as for all
> other callers the value is ignored, too.
>
> Also fold in a small checkpatch fix for:
>
> WARNING: Unnecessary space before function pointer arguments
> +       void (*remove) (struct parisc_device *dev);
>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@...il.com> (for drivers/input)
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
> changes since v1 sent with Message-Id:
> 20210806093938.1950990-1-u.kleine-koenig@...gutronix.de:
>
>  - Fix a compiler error noticed by the kernel test robot
>  - Add Ack for Dmitry
>
>  arch/parisc/include/asm/parisc-device.h  | 4 ++--
>  drivers/char/ipmi/ipmi_si.h              | 2 +-
>  drivers/char/ipmi/ipmi_si_intf.c         | 6 +-----
>  drivers/char/ipmi/ipmi_si_parisc.c       | 4 ++--
>  drivers/char/ipmi/ipmi_si_platform.c     | 4 +++-
>  drivers/input/keyboard/hilkbd.c          | 4 +---
>  drivers/input/serio/gscps2.c             | 3 +--
>  drivers/net/ethernet/i825xx/lasi_82596.c | 3 +--
>  drivers/parport/parport_gsc.c            | 3 +--

Acked-by:  Sudip Mukherjee <sudipm.mukherjee@...il.com>


-- 
Regards
Sudip