netdev - Re: [PATCH net] nfp: update ethtool reporting of pauseframe control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YQ3tVX0CSUad9M1B@lunn.ch>
Date:   Sat, 7 Aug 2021 04:17:57 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        oss-drivers@...igine.com, Fei Qin <fei.qin@...igine.com>,
        Louis Peens <louis.peens@...igine.com>
Subject: Re: [PATCH net] nfp: update ethtool reporting of pauseframe control

On Fri, Aug 06, 2021 at 11:38:57AM +0200, Simon Horman wrote:
> On Tue, Aug 03, 2021 at 05:50:26PM +0200, Simon Horman wrote:
> > On Tue, Aug 03, 2021 at 05:03:33PM +0200, Andrew Lunn wrote:
> > > On Tue, Aug 03, 2021 at 12:39:11PM +0200, Simon Horman wrote:
> > > > From: Fei Qin <fei.qin@...igine.com>
> > > > 
> > > > Pauseframe control is set to symmetric mode by default on the NFP.
> > > > Pause frames can not be configured through ethtool now, but ethtool can
> > > > report the supported mode.
> > > > 
> > > > Fixes: 265aeb511bd5 ("nfp: add support for .get_link_ksettings()")
> > > > Signed-off-by: Fei Qin <fei.qin@...igine.com>
> > > > Signed-off-by: Louis Peens <louis.peens@...igine.com>
> > > > Signed-off-by: Simon Horman <simon.horman@...igine.com>
> > > > ---
> > > >  drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > > 
> > > > diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> > > > index 1b482446536d..8803faadd302 100644
> > > > --- a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> > > > +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> > > > @@ -286,6 +286,8 @@ nfp_net_get_link_ksettings(struct net_device *netdev,
> > > >  
> > > >  	/* Init to unknowns */
> > > >  	ethtool_link_ksettings_add_link_mode(cmd, supported, FIBRE);
> > > > +	ethtool_link_ksettings_add_link_mode(cmd, supported, Pause);
> > > > +	ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
> > > 
> > > Hi Simon
> > > 
> > > Does it act on the results of the pause auto-neg? If the link peer
> > > says it does not support pause, will it turn pause off?
> > 
> > Thanks Andrew,
> > 
> > I'll try and get an answer to that question for you.
> 
> Hi Andrew,
> 
> The simple answer to those questions is no.

Hi Simon

Then please send a patch removing Pause from advertising, and ensure
your PHY, SERDES etc, does not advertise it.

It seems like all the smart NICs get pause wrong.

   Andrew