[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 8 Aug 2021 17:29:44 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Luo Jie <luoj@...eaurora.org>
Cc: hkallweit1@...il.com, davem@...emloft.net, kuba@...nel.org,
linux@...linux.org.uk, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, sricharan@...eaurora.org
Subject: Re: [PATCH v1 1/2] net: mdio: Add the reset function for IPQ MDIO
driver
> + /* Configure MDIO clock source frequency if clock is specified in the device tree */
> + if (!IS_ERR_OR_NULL(priv->mdio_clk)) {
Please document the clock in the binding. Make it clear which devices
require the clock, and which don't.
Andrew
Powered by blists - more mailing lists