lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sun, 8 Aug 2021 12:17:06 -0600
From:   David Ahern <dsahern@...il.com>
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc:     Jay Vosburgh <j.vosburgh@...il.com>,
        Veaceslav Falico <vfalico@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        Jarod Wilson <jarod@...hat.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH iproute2-next] ip/bond: add lacp active support

On 8/1/21 9:02 PM, Hangbin Liu wrote:
> @@ -316,6 +324,13 @@ static int bond_parse_opt(struct link_util *lu, int argc, char **argv,
>  
>  			addattr32(n, 1024, IFLA_BOND_PACKETS_PER_SLAVE,
>  				  packets_per_slave);
> +		} else if (matches(*argv, "lacp_active") == 0) {
> +			NEXT_ARG();
> +			if (get_index(lacp_active_tbl, *argv) < 0)
> +				invarg("invalid lacp_active", *argv);
> +
> +			lacp_active = get_index(lacp_active_tbl, *argv);
> +			addattr8(n, 1024, IFLA_BOND_AD_LACP_ACTIVE, lacp_active);
>  		} else if (matches(*argv, "lacp_rate") == 0) {

The new argument needs to go after the older "lacp_rate" since it uses
matches. Also, let's stop using matches and move to a full strcmp for
new options.

Powered by blists - more mailing lists