lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 9 Aug 2021 07:04:02 +0200 From: Oleksij Rempel <o.rempel@...gutronix.de> To: Vladimir Oltean <olteanv@...il.com> Cc: Andrew Lunn <andrew@...n.ch>, Vivien Didelot <vivien.didelot@...il.com>, Florian Fainelli <f.fainelli@...il.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Russell King <linux@...linux.org.uk>, Pengutronix Kernel Team <kernel@...gutronix.de>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org Subject: Re: [PATCH net-next v3 5/6] net: dsa: qca: ar9331: add bridge support On Sun, Aug 08, 2021 at 02:08:29AM +0300, Vladimir Oltean wrote: > Hi Oleksij, > > On Mon, Aug 02, 2021 at 03:10:36PM +0200, Oleksij Rempel wrote: > > This switch is providing forwarding matrix, with it we can configure > > individual bridges. Potentially we can configure more than one not VLAN > > based bridge on this HW. > > > > Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de> > > Reviewed-by: Florian Fainelli <f.fainelli@...il.com> > > --- > > I don't see anywhere in this patch or in this series that the > tag_ar9331.c file is being patched to set skb->offload_fwd_mark to true > for packets sent (flooded) to the CPU that have already been forwarded > by the hardware switch. If the software bridge sees a broadcast packet > coming from your driver and it has offload_fwd_mark = false, it will > forward it a second time and the other nodes in your network will see > duplicates. Ok, thank you, I'll take a look on it. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Powered by blists - more mailing lists