netdev - Re: [PATCH] netlink: NL_SET_ERR_MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c32a4a3c-c7df-cb8d-ecb4-7c1738cfd15c@redhat.com>
Date:   Mon, 9 Aug 2021 18:30:33 -0400
From:   Jonathan Toppins <jtoppins@...hat.com>
To:     Joe Perches <joe@...ches.com>, netdev <netdev@...r.kernel.org>
Cc:     Johannes Berg <johannes.berg@...el.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] netlink: NL_SET_ERR_MSG - remove local static array

On 8/9/21 1:04 PM, Joe Perches wrote:
> The want was to have some separate object section for netlink messages
> so all netlink messages could be specifically listed by some tool but
> the effect is duplicating static const char arrays in the object code.
> 
> It seems unused presently so change the macro to avoid the local static
> declarations until such time as these actually are wanted and used.
> 
> This reduces object size ~8KB in an x86-64 defconfig without modules.
> 
> $ size vmlinux.o*
>     text	   data	    bss	    dec	    hex	filename
> 20110471	3460344	 741760	24312575	172faff	vmlinux.o.new
> 20119444	3460344	 741760	24321548	1731e0c	vmlinux.o.old
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Seems reasonable.

Acked-by: Jonathan Toppins <jtoppins@...hat.com>