netdev - Re: [PATCH] net: mscc: Fix non-GPL export of regmap APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YRJ17eMJPjx2fOtm@piout.net>
Date:   Tue, 10 Aug 2021 14:49:49 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Vladimir Oltean <vladimir.oltean@....com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        UNGLinuxDriver@...rochip.com,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: mscc: Fix non-GPL export of regmap APIs

On 10/08/2021 13:37:48+0100, Mark Brown wrote:
> The ocelot driver makes use of regmap, wrapping it with driver specific
> operations that are thin wrappers around the core regmap APIs. These are
> exported with EXPORT_SYMBOL, dropping the _GPL from the core regmap
> exports which is frowned upon. Add _GPL suffixes to at least the APIs that
> are doing register I/O.
> 
> Signed-off-by: Mark Brown <broonie@...nel.org>
Acked-by: Alexandre Belloni <alexandre.belloni@...tlin.com>

> ---
>  drivers/net/ethernet/mscc/ocelot_io.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mscc/ocelot_io.c b/drivers/net/ethernet/mscc/ocelot_io.c
> index ea4e83410fe4..7390fa3980ec 100644
> --- a/drivers/net/ethernet/mscc/ocelot_io.c
> +++ b/drivers/net/ethernet/mscc/ocelot_io.c
> @@ -21,7 +21,7 @@ u32 __ocelot_read_ix(struct ocelot *ocelot, u32 reg, u32 offset)
>  		    ocelot->map[target][reg & REG_MASK] + offset, &val);
>  	return val;
>  }
> -EXPORT_SYMBOL(__ocelot_read_ix);
> +EXPORT_SYMBOL_GPL(__ocelot_read_ix);
>  
>  void __ocelot_write_ix(struct ocelot *ocelot, u32 val, u32 reg, u32 offset)
>  {
> @@ -32,7 +32,7 @@ void __ocelot_write_ix(struct ocelot *ocelot, u32 val, u32 reg, u32 offset)
>  	regmap_write(ocelot->targets[target],
>  		     ocelot->map[target][reg & REG_MASK] + offset, val);
>  }
> -EXPORT_SYMBOL(__ocelot_write_ix);
> +EXPORT_SYMBOL_GPL(__ocelot_write_ix);
>  
>  void __ocelot_rmw_ix(struct ocelot *ocelot, u32 val, u32 mask, u32 reg,
>  		     u32 offset)
> @@ -45,7 +45,7 @@ void __ocelot_rmw_ix(struct ocelot *ocelot, u32 val, u32 mask, u32 reg,
>  			   ocelot->map[target][reg & REG_MASK] + offset,
>  			   mask, val);
>  }
> -EXPORT_SYMBOL(__ocelot_rmw_ix);
> +EXPORT_SYMBOL_GPL(__ocelot_rmw_ix);
>  
>  u32 ocelot_port_readl(struct ocelot_port *port, u32 reg)
>  {
> @@ -58,7 +58,7 @@ u32 ocelot_port_readl(struct ocelot_port *port, u32 reg)
>  	regmap_read(port->target, ocelot->map[target][reg & REG_MASK], &val);
>  	return val;
>  }
> -EXPORT_SYMBOL(ocelot_port_readl);
> +EXPORT_SYMBOL_GPL(ocelot_port_readl);
>  
>  void ocelot_port_writel(struct ocelot_port *port, u32 val, u32 reg)
>  {
> @@ -69,7 +69,7 @@ void ocelot_port_writel(struct ocelot_port *port, u32 val, u32 reg)
>  
>  	regmap_write(port->target, ocelot->map[target][reg & REG_MASK], val);
>  }
> -EXPORT_SYMBOL(ocelot_port_writel);
> +EXPORT_SYMBOL_GPL(ocelot_port_writel);
>  
>  void ocelot_port_rmwl(struct ocelot_port *port, u32 val, u32 mask, u32 reg)
>  {
> @@ -77,7 +77,7 @@ void ocelot_port_rmwl(struct ocelot_port *port, u32 val, u32 mask, u32 reg)
>  
>  	ocelot_port_writel(port, (cur & (~mask)) | val, reg);
>  }
> -EXPORT_SYMBOL(ocelot_port_rmwl);
> +EXPORT_SYMBOL_GPL(ocelot_port_rmwl);
>  
>  u32 __ocelot_target_read_ix(struct ocelot *ocelot, enum ocelot_target target,
>  			    u32 reg, u32 offset)
> @@ -128,7 +128,7 @@ int ocelot_regfields_init(struct ocelot *ocelot,
>  
>  	return 0;
>  }
> -EXPORT_SYMBOL(ocelot_regfields_init);
> +EXPORT_SYMBOL_GPL(ocelot_regfields_init);
>  
>  static struct regmap_config ocelot_regmap_config = {
>  	.reg_bits	= 32,
> @@ -148,4 +148,4 @@ struct regmap *ocelot_regmap_init(struct ocelot *ocelot, struct resource *res)
>  
>  	return devm_regmap_init_mmio(ocelot->dev, regs, &ocelot_regmap_config);
>  }
> -EXPORT_SYMBOL(ocelot_regmap_init);
> +EXPORT_SYMBOL_GPL(ocelot_regmap_init);
> -- 
> 2.20.1
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com