netdev - Re: [PATCH iproute2-next] devlink: Show port state values in man page and in the help command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b476bdd-dc87-4ddf-08b1-e2aaf7cca7f6@gmail.com>
Date:   Tue, 10 Aug 2021 07:18:11 -0600
From:   David Ahern <dsahern@...il.com>
To:     Parav Pandit <parav@...dia.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "dsahern@...nel.org" <dsahern@...nel.org>,
        "stephen@...workplumber.org" <stephen@...workplumber.org>
Cc:     Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH iproute2-next] devlink: Show port state values in man page
 and in the help command

On 8/10/21 5:49 AM, Parav Pandit wrote:
> Hi David, Stephen,
> 
>> From: Parav Pandit <parav@...dia.com>
>> Sent: Friday, July 23, 2021 8:24 PM
>>
>> Port function state can have either of the two values - active or inactive.
>> Update the documentation and help command for these two values to tell
>> user about it.
>>
>> With the introduction of state, hw_addr and state are optional.
>> Hence mark them as optional in man page that also aligns with the help
>> command output.
>>
>> Fixes: bdfb9f1bd61a ("devlink: Support set of port function state")
>> Signed-off-by: Parav Pandit <parav@...dia.com>
>> Reviewed-by: Jiri Pirko <jiri@...dia.com>
>> ---
>>  devlink/devlink.c       |  2 +-
>>  man/man8/devlink-port.8 | 10 +++++-----
>>  2 files changed, 6 insertions(+), 6 deletions(-)
>>
> Can you please review this short fix?
> 

It is assigned to Stephen, but some how marked as 'archived'. I removed
that label and it is back in Stephen's list.