netdev - Re: [PATCH v5 net-next 04/36] net/tls: expose get_netdev_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ3xEMhozmy3kDNU1=1kEM3Wqgvb4bFpMC7Wxrwq=U2xYMOMtg@mail.gmail.com>
Date:   Tue, 10 Aug 2021 16:25:02 +0300
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     Christoph Hellwig <hch@....de>
Cc:     Boris Pismenny <borisp@...dia.com>,
        Linux Netdev List <netdev@...r.kernel.org>,
        Sagi Grimberg <sagi@...mberg.me>,
        Yoray Zack <yorayz@...dia.com>, benishay@...dia.com,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH v5 net-next 04/36] net/tls: expose get_netdev_for_sock

On Wed, Aug 4, 2021 at 6:07 PM Or Gerlitz <gerlitz.or@...il.com> wrote:
> On Wed, Aug 4, 2021 at 5:29 PM Jakub Kicinski <kuba@...nel.org> wrote:
> > On Wed, 4 Aug 2021 16:26:31 +0300 Or Gerlitz wrote:
> > > On Fri, Jul 23, 2021 at 9:09 AM Christoph Hellwig <hch@....de> wrote:
> > > > On Thu, Jul 22, 2021 at 02:02:53PM +0300, Boris Pismenny wrote:
> > > > > From: Boris Pismenny <borisp@...lanox.com>
> > > > >
> > > > > get_netdev_for_sock is a utility that is used to obtain
> > > > > the net_device structure from a connected socket.
> > > > >
> > > > > Later patches will use this for nvme-tcp DDP and DDP DDGST offloads.
> > > > >
> > > > > Signed-off-by: Boris Pismenny <borisp@...lanox.com>
> > > > > Reviewed-by: Sagi Grimberg <sagi@...mberg.me>
> > > >
> > > > I don't think this should be an inline.  Please move it to net/core/dev.c,
> > > > andd add an EXPORT_SYMBOL_GPL and a kerneldoc comment.

> > > Jakub,
> > > What's your preference here?

> > Fine either way.

> copying the list and few ppl

Christoph,

We will add the kdoc.

Prefer to leave it as inline which is fine by the networking maintainer.

Or.