netdev - Re: [PATCH net-next 5/5] igc: Export LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Aug 2021 23:21:54 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Pavel Machek <pavel@....cz>,
        Marek Behún <kabel@...nel.org>,
        Michael Walle <michael@...le.cc>, anthony.l.nguyen@...el.com,
        bigeasy@...utronix.de, davem@...emloft.net,
        dvorax.fuxbrumer@...ux.intel.com, f.fainelli@...il.com,
        jacek.anaszewski@...il.com, kuba@...nel.org, kurt@...utronix.de,
        linux-leds@...r.kernel.org, netdev@...r.kernel.org,
        sasha.neftin@...el.com, vinicius.gomes@...el.com,
        vitaly.lifshits@...el.com
Subject: Re: [PATCH net-next 5/5] igc: Export LEDs

> A challenge here would be unique numbering if there are multiple
> network interfaces with LED support (especially if the interfaces
> use different drivers). So the numbering service would have to be
> in LED subsystem core or network subsystem core.

Yes, it needs to be somewhere common.

We also need to document that the number is meaningless and
arbitrary. It can change from boot to boot. Also, LEDs from the same
PHY or MAC are not guaranteed to be contiguous, since multiple
PHYs/MACs can be enumerating their LEDs at the same time.

     Andrew