lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Aug 2021 03:05:27 +0200 From: Andrew Lunn <andrew@...n.ch> To: Vladimir Oltean <vladimir.oltean@....com> Cc: netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>, "David S. Miller" <davem@...emloft.net>, Florian Fainelli <f.fainelli@...il.com>, Vivien Didelot <vivien.didelot@...il.com>, Vladimir Oltean <olteanv@...il.com>, Linus Walleij <linus.walleij@...aro.org>, DENG Qingfang <dqfext@...il.com>, John Crispin <john@...ozen.org>, Sean Wang <sean.wang@...iatek.com>, Landen Chao <Landen.Chao@...iatek.com> Subject: Re: [RFC PATCH net-next 3/4] net: dsa: create a helper for locating EtherType DSA headers on RX On Mon, Aug 09, 2021 at 02:57:21PM +0300, Vladimir Oltean wrote: > It seems that protocol tagging driver writers are always surprised about > the formula they use to reach their EtherType header on RX, which > becomes apparent from the fact that there are comments in multiple > drivers that mention the same information. > > Create a helper that returns a void pointer to skb->data - 2, as well as > centralize the explanation why that is the case. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com> Reviewed-by: Andrew Lunn <andrew@...n.ch> Andrew
Powered by blists - more mailing lists