netdev - Re: [net-next PATCH v2] net/sched: cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YRItrkt3capthkUE@shredder>
Date:   Tue, 10 Aug 2021 10:41:34 +0300
From:   Ido Schimmel <idosch@...sch.org>
To:     Mark Bloch <mbloch@...dia.com>
Cc:     netdev@...r.kernel.org, xiyou.wangcong@...il.com,
        vladbu@...dia.com, cong.wang@...edance.com, jhs@...atatu.com,
        jiri@...nulli.us
Subject: Re: [net-next PATCH v2] net/sched: cls_api, reset flags on replay

On Tue, Aug 10, 2021 at 03:43:05AM +0000, Mark Bloch wrote:
> tc_new_tfilter() can replay a request if it got EAGAIN. The cited commit
> didn't account for this when it converted TC action ->init() API
> to use flags instead of parameters. This can lead to passing stale flags
> down the call chain which results in trying to lock rtnl when it's
> already locked, deadlocking the entire system.
> 
> Fix by making sure to reset flags on each replay.

[...]

> Fixes: 695176bfe5de ("net_sched: refactor TC action init API")
> Signed-off-by: Mark Bloch <mbloch@...dia.com>
> Reviewed-by: Vlad Buslov <vladbu@...dia.com>

Reviewed-by: Ido Schimmel <idosch@...dia.com>
Tested-by: Ido Schimmel <idosch@...dia.com>