netdev - Re: [PATCH v2] net/mlx5e: Make use of mlx5_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d1456c73eecbe4ccb0353a275d1a48b334389bb3.camel@nvidia.com>
Date:   Tue, 10 Aug 2021 08:22:03 +0000
From:   Saeed Mahameed <saeedm@...dia.com>
To:     "leon@...nel.org" <leon@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "caihuoqing@...du.com" <caihuoqing@...du.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
Subject: Re: [PATCH v2] net/mlx5e: Make use of mlx5_core_warn()

On Tue, 2021-08-10 at 09:58 +0300, Leon Romanovsky wrote:
> On Mon, Aug 09, 2021 at 08:39:10PM +0000, Saeed Mahameed wrote:
> > On Mon, 2021-08-09 at 20:19 +0800, Cai Huoqing wrote:
> > > to replace printk(KERN_WARNING ...) with mlx5_core_warn() kindly
> > > if we use mlx5_core_warn(), the prefix "mlx5:" not needed
> > 
> > in mlx5e it is netdev stack so netdev_warn(priv->netdev, "foo bar");
> 
> Saeed,
> 
> That file is full of mlx5_core_* prints, even in the same function
> where
> Cai is changing, you will find mlx5_core_warn().
> 

$ git grep -E "mlx5_core_(warn|info|err)" 
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c  | wc -l
4

$ git grep -E "netdev_(warn|info|err)" 
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c  | wc -l
24

4 vs 24, a big win for netdev ;-)

4 is not full. Many of mlx5 files has some leftovers historical code,
doesn't mean we need to keep the old habits ..