netdev - Re: [RFC PATCH net-next 3/4] net: dsa: create a helper for locating EtherType DSA headers on RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8da86b9-973c-f678-509f-c6fac2c7bbb9@gmail.com>
Date:   Tue, 10 Aug 2021 02:21:41 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        DENG Qingfang <dqfext@...il.com>,
        John Crispin <john@...ozen.org>,
        Sean Wang <sean.wang@...iatek.com>,
        Landen Chao <Landen.Chao@...iatek.com>
Subject: Re: [RFC PATCH net-next 3/4] net: dsa: create a helper for locating
 EtherType DSA headers on RX



On 8/9/2021 4:57 AM, Vladimir Oltean wrote:
> It seems that protocol tagging driver writers are always surprised about
> the formula they use to reach their EtherType header on RX, which
> becomes apparent from the fact that there are comments in multiple
> drivers that mention the same information.
> 
> Create a helper that returns a void pointer to skb->data - 2, as well as
> centralize the explanation why that is the case.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian