netdev - Re: [PATCH v2 net-next 0/4] DSA tagger helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZc4S0nLgz=BP8H_3XBZa9NfiUaW5aXiRxR+whnDsCCaA@mail.gmail.com>
Date:   Wed, 11 Aug 2021 15:29:35 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     netdev <netdev@...r.kernel.org>, Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        DENG Qingfang <dqfext@...il.com>,
        John Crispin <john@...ozen.org>,
        Sean Wang <sean.wang@...iatek.com>,
        Landen Chao <Landen.Chao@...iatek.com>
Subject: Re: [PATCH v2 net-next 0/4] DSA tagger helpers

On Tue, Aug 10, 2021 at 3:14 PM Vladimir Oltean <vladimir.oltean@....com> wrote:

> The goal of this series is to minimize the use of memmove and skb->data
> in the DSA tagging protocol drivers. Unfiltered access to this level of
> information is not very friendly to drive-by contributors, and sometimes
> is also not the easiest to review.
>
> For starters, I have converted the most common form of DSA tagging
> protocols: the DSA headers which are placed where the EtherType is.
>
> The helper functions introduced by this series are:
> - dsa_alloc_etype_header
> - dsa_strip_etype_header
> - dsa_etype_header_pos_rx
> - dsa_etype_header_pos_tx
>
> This series is just a resend as non-RFC of v1.

The series:
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij