netdev - RE: [BUG] net: qed: possible null-pointer dereference in qed_rdma_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <SJ0PR18MB38825C9DE41C67DEC36F3DAACCF89@SJ0PR18MB3882.namprd18.prod.outlook.com>
Date:   Wed, 11 Aug 2021 09:44:38 +0000
From:   Shai Malin <smalin@...vell.com>
To:     Tuo Li <islituo@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        "baijiaju1990@...il.com" <baijiaju1990@...il.com>,
        Ariel Elior <aelior@...vell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "malin1024@...il.com" <malin1024@...il.com>
Subject: RE: [BUG] net: qed: possible null-pointer dereference in
 qed_rdma_create_qp()

On 8/11/21 6:30 AM, Tuo Li wrote:
> Hello,
> 
> Our static analysis tool finds a possible null-pointer dereference in
> qed_rdma.c in Linux 5.14.0-rc3:
> 
> The variable rdma_cxt is assigned to p_hwfn, and rdma_cxt is checked in:
> 1286:    if (!rdma_cxt || !in_params || !out_params ||
> !p_hwfn->p_rdma_info->active)
> 
> This indicates that both rdma_cxt and p_hwfn can be NULL. If so, a
> null-pointer dereference will occur:
> 1288:    DP_ERR(p_hwfn->cdev, ...);
> 
> I am not quite sure whether this possible null-pointer dereference is
> real and how to fix it if it is real.
> Any feedback would be appreciated, thanks!
> 
> Reported-by: TOTE Robot <oslab@...nghua.edu.cn>

Thanks! It's a real issue.
We will send a fix.

> 
> Best wishes,
> Tuo Li