netdev - Re: [RFC PATCH net-next 2/4] net: dsa: create a helper which allocates space for EtherType DSA headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZMyJ4ZnyKrMgEpBmGh0=8vTjkMn0r2xkdBnF2D7Xwc_Q@mail.gmail.com>
Date:   Wed, 11 Aug 2021 15:24:22 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     netdev <netdev@...r.kernel.org>, Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        DENG Qingfang <dqfext@...il.com>,
        John Crispin <john@...ozen.org>,
        Sean Wang <sean.wang@...iatek.com>,
        Landen Chao <Landen.Chao@...iatek.com>
Subject: Re: [RFC PATCH net-next 2/4] net: dsa: create a helper which
 allocates space for EtherType DSA headers

On Mon, Aug 9, 2021 at 1:57 PM Vladimir Oltean <vladimir.oltean@....com> wrote:

> Hide away the memmove used by DSA EtherType header taggers to shift the
> MAC SA and DA to the left to make room for the header, after they've
> called skb_push(). The call to skb_push() is still left explicit in
> drivers, to be symmetric with dsa_strip_etype_header, and because not
> all callers can be refactored to do it (for example, brcm_tag_xmit_ll
> has common code for a pre-Ethernet DSA tag and an EtherType DSA tag).
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij