netdev - Re: [PATCH] netfilter: remove duplicate code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210812143120.GD607@breakpoint.cc>
Date:   Thu, 12 Aug 2021 16:31:20 +0200
From:   Florian Westphal <fw@...len.de>
To:     Kangmin Park <l4stpr0gr4m@...il.com>
Cc:     Pablo Neira Ayuso <pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...filter.org>,
        Florian Westphal <fw@...len.de>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netfilter: remove duplicate code

Kangmin Park <l4stpr0gr4m@...il.com> wrote:
> I checked the Changes Requested state in patchwork.
> But I have not received any review mails.

I did not see any either.

> I wonder if there is any problem.

I don't think its worth doing, the 'extra' check avoids the
need for two additional function arguments (and those are not free
either).