netdev - Re: [PATCH iproute2] lib: bpf_glue: remove useless assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210812092656.2b9167fc@hermes.local>
Date:   Thu, 12 Aug 2021 09:26:56 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Andrea Claudi <aclaudi@...hat.com>
Cc:     netdev@...r.kernel.org, dsahern@...il.com, haliu@...hat.com
Subject: Re: [PATCH iproute2] lib: bpf_glue: remove useless assignment

On Thu, 12 Aug 2021 11:01:42 +0200
Andrea Claudi <aclaudi@...hat.com> wrote:

> On Wed, Aug 11, 2021 at 09:08:15AM -0700, Stephen Hemminger wrote:
> > It is bad style in C to do assignment in a conditional.
> > It causes errors, and is not anymore efficient.
> >   
> I agree with you.
> 
> There is a large number of similar assignments in other parts of the
> code; I can work on a treewide patch to address them all, if you think
> it's a good idea.
> 

I am looking into this, checkpatch seems to find them