netdev - Re: [PATCH] af_unix: fix holding spinlock in oob handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a807dd9c-4f8a-c205-8fa0-01effdd54553@oracle.com>
Date:   Thu, 12 Aug 2021 10:37:49 -0700
From:   Shoaib Rao <rao.shoaib@...cle.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     netdev <netdev@...r.kernel.org>, Jakub Kicinski <kuba@...nel.org>,
        Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH] af_unix: fix holding spinlock in oob handling


On 8/12/21 12:53 AM, Eric Dumazet wrote:
>          if (ousk->oob_skb)
> -               kfree_skb(ousk->oob_skb);
> +               consume_skb(ousk->oob_skb);

Should I be using consume_skb(), as the skb is not being consumed, the 
ref count is decremented and if zero skb will be freed.

Shoaib