netdev - Re: [PATCH net-next 2/3] ptp: ocp: Fix error path for pci_ocp_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210812145951.6e5c62f4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 12 Aug 2021 14:59:51 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jonathan Lemon <jonathan.lemon@...il.com>
Cc:     davem@...emloft.net, richardcochran@...il.com,
        netdev@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH net-next 2/3] ptp: ocp: Fix error path for
 pci_ocp_device_init()

On Wed, 11 Aug 2021 11:31:32 -0700 Jonathan Lemon wrote:
> If ptp_ocp_device_init() fails, pci_disable_device() is skipped.
> Fix the error handling so this case is covered.  Update ptp_ocp_remove()
> so the normal exit path is identical.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Jonathan Lemon <jonathan.lemon@...il.com>

Fixes tag would be useful on this and previous patch to make it clear
the problems are only present in net-next.