netdev - Re: [PATCH net v3 0/4] bnxt: Tx NAPI disabling resiliency improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKOOJTywyN7+6udvgYLmt_coYNZvN-Tkk+UyPMSMOaZFxw4gzg@mail.gmail.com>
Date:   Thu, 12 Aug 2021 15:35:15 -0700
From:   Edwin Peer <edwin.peer@...adcom.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Michael Chan <michael.chan@...adcom.com>,
        Prashant Sreedharan <prashant@...adcom.com>,
        Eddie Wai <eddie.wai@...adcom.com>,
        Jeffrey Huang <huangjw@...adcom.com>,
        Andrew Gospodarek <gospo@...adcom.com>
Subject: Re: [PATCH net v3 0/4] bnxt: Tx NAPI disabling resiliency improvements

Reviewed-by: Edwin Peer <edwin.peer@...adcom.com>

Regards,
Edwin Peer

On Thu, Aug 12, 2021 at 2:42 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> A lockdep warning was triggered by netpoll because napi poll
> was taking the xmit lock. Fix that and a couple more issues
> noticed while reading the code.
>
> Jakub Kicinski (4):
>   bnxt: don't lock the tx queue from napi poll
>   bnxt: disable napi before canceling DIM
>   bnxt: make sure xmit_more + errors does not miss doorbells
>   bnxt: count Tx drops
>
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 98 ++++++++++++++---------
>  drivers/net/ethernet/broadcom/bnxt/bnxt.h |  1 +
>  2 files changed, 62 insertions(+), 37 deletions(-)
>
> --
> 2.31.1
>