netdev - Re: [net-next 05/12] net/mlx5: Change SF missing dedicated MSI-X err message to dbg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YRTIo8Op1MuHL6Am@unreal>
Date:   Thu, 12 Aug 2021 10:07:15 +0300
From:   Leon Romanovsky <leonro@...dia.com>
To:     Saeed Mahameed <saeed@...nel.org>
CC:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...dia.com>,
        Shay Drory <shayd@...dia.com>, Parav Pandit <parav@...dia.com>,
        Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [net-next 05/12] net/mlx5: Change SF missing dedicated MSI-X err
 message to dbg

On Wed, Aug 11, 2021 at 11:16:51AM -0700, Saeed Mahameed wrote:
> From: Shay Drory <shayd@...dia.com>
> 
> When MSI-X vectors allocated are not enough for SFs to have dedicated,
> MSI-X, kernel log buffer has too many entries.
> Hence only enable such log with debug level.

Please invest extra time in the commit message.

> 
> Signed-off-by: Shay Drory <shayd@...dia.com>
> Reviewed-by: Parav Pandit <parav@...dia.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c b/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c
> index a4f6ba0c91da..717b9f1850ac 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c
> @@ -479,7 +479,7 @@ static int irq_pools_init(struct mlx5_core_dev *dev, int sf_vec, int pf_vec)
>  	if (!mlx5_sf_max_functions(dev))
>  		return 0;
>  	if (sf_vec < MLX5_IRQ_VEC_COMP_BASE_SF) {
> -		mlx5_core_err(dev, "Not enough IRQs for SFs. SF may run at lower performance\n");
> +		mlx5_core_dbg(dev, "Not enught IRQs for SFs. SF may run at lower performance\n");

enught -> enough

>  		return 0;
>  	}
>  
> -- 
> 2.31.1
>