netdev - RE: [PATCH 3/3] net: dpaa_eth: remove dead select in menuconfig FSL_DPAA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM6PR04MB3976A72707A65CB74B11AFFCECF99@AM6PR04MB3976.eurprd04.prod.outlook.com>
Date:   Thu, 12 Aug 2021 08:42:29 +0000
From:   "Madalin Bucur (OSS)" <madalin.bucur@....nxp.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Camelia Alexandra Groza (OSS)" <camelia.groza@....nxp.com>
CC:     Randy Dunlap <rdunlap@...radead.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 3/3] net: dpaa_eth: remove dead select in menuconfig
 FSL_DPAA_ETH

> -----Original Message-----
> From: Lukas Bulwahn <lukas.bulwahn@...il.com>
> Sent: 12 August 2021 11:38
> To: David S . Miller <davem@...emloft.net>; Jakub Kicinski
> <kuba@...nel.org>; netdev@...r.kernel.org
> Cc: Madalin Bucur <madalin.bucur@....com>; Randy Dunlap
> <rdunlap@...radead.org>; kernel-janitors@...r.kernel.org; linux-
> kernel@...r.kernel.org; Lukas Bulwahn <lukas.bulwahn@...il.com>
> Subject: [PATCH 3/3] net: dpaa_eth: remove dead select in menuconfig
> FSL_DPAA_ETH
> 
> The menuconfig FSL_DPAA_ETH selects config FSL_FMAN_MAC, but the config
> FSL_FMAN_MAC never existed in the kernel tree.
> 
> Hence, ./scripts/checkkconfigsymbols.py warns:
> 
> FSL_FMAN_MAC
> Referencing files: drivers/net/ethernet/freescale/dpaa/Kconfig
> 
> Remove this dead select in menuconfig FSL_DPAA_ETH.
> 
> Fixes: 9ad1a3749333 ("dpaa_eth: add support for DPAA Ethernet")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> ---
>  drivers/net/ethernet/freescale/dpaa/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/dpaa/Kconfig
> b/drivers/net/ethernet/freescale/dpaa/Kconfig
> index 626ec58a0afc..0e1439fd00bd 100644
> --- a/drivers/net/ethernet/freescale/dpaa/Kconfig
> +++ b/drivers/net/ethernet/freescale/dpaa/Kconfig
> @@ -4,7 +4,6 @@ menuconfig FSL_DPAA_ETH
>  	depends on FSL_DPAA && FSL_FMAN
>  	select PHYLIB
>  	select FIXED_PHY
> -	select FSL_FMAN_MAC
>  	help
>  	  Data Path Acceleration Architecture Ethernet driver,
>  	  supporting the Freescale QorIQ chips.
> --
> 2.17.1

Acked-by: Madalin Bucur <madalin.bucur@....nxp.com>