lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Aug 2021 13:17:03 +0300 From: Vladimir Oltean <olteanv@...il.com> To: DENG Qingfang <dqfext@...il.com> Cc: Ido Schimmel <idosch@...sch.org>, Roopa Prabhu <roopa@...dia.com>, Nikolay Aleksandrov <nikolay@...dia.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, "moderated list:ETHERNET BRIDGE" <bridge@...ts.linux-foundation.org>, "open list:ETHERNET BRIDGE" <netdev@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>, Florian Fainelli <f.fainelli@...il.com> Subject: Re: [PATCH net-next] net: bridge: switchdev: allow port isolation to be offloaded On Thu, Aug 12, 2021 at 02:04:10PM +0800, DENG Qingfang wrote: > On Thu, Aug 12, 2021 at 12:58:33AM +0300, Vladimir Oltean wrote: > > On Thu, Aug 12, 2021 at 12:52:48AM +0300, Ido Schimmel wrote: > > > > > > If the purpose is correctness, then this is not the only flag that was > > > missed. BR_HAIRPIN_MODE is also relevant for the data path, for example. > > > > I never wanted to suggest that I'm giving a comprehensive answer, I just > > answered Qingfang's punctual question here: > > https://lore.kernel.org/netdev/CALW65jbotyW0MSOd-bd1TH_mkiBWhhRCQ29jgn+d12rXdj2pZA@mail.gmail.com/ > > > > Tobias also pointed out the same issue about BR_MULTICAST_TO_UNICAST in > > conjunction with tx_fwd_offload (although the same is probably true even > > without it): > > https://patchwork.kernel.org/project/netdevbpf/cover/20210426170411.1789186-1-tobias@waldekranz.com/ > > > > > Anyway, the commit message needs to be reworded to reflect the true > > > purpose of the patch. > > > > Agree, and potentially extended with all the bridge port flags which are > > broken without switchdev driver intervention. > > So, what else flags should be added to BR_PORT_FLAGS_HW_OFFLOAD? I can't think of others beside these 3, BR_ISOLATED, BR_HAIRPIN_MODE and BR_MULTICAST_TO_UNICAST.
Powered by blists - more mailing lists