netdev - Re: [PATCH v2 1/3] net: mdio: Add the reset function for IPQ MDIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fb49c1e3-c4f6-0d72-0def-8cae734fc3ff@codeaurora.org>
Date:   Thu, 12 Aug 2021 10:39:51 +0800
From:   Jie Luo <luoj@...eaurora.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     agross@...nel.org, bjorn.andersson@...aro.org, davem@...emloft.net,
        kuba@...nel.org, robh+dt@...nel.org, hkallweit1@...il.com,
        linux@...linux.org.uk, robert.marko@...tura.hr,
        linux-arm-msm@...r.kernel.org, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        sricharan@...eaurora.org
Subject: Re: [PATCH v2 1/3] net: mdio: Add the reset function for IPQ MDIO
 driver


On 8/11/2021 10:57 PM, Andrew Lunn wrote:
>> +	ret = clk_prepare_enable(priv->mdio_clk);
>> +	if (ret)
>> +		return ret;
>> +
>> +	return 0;
> This can be simplified to just:
>
>       return clk_prepare_enable(priv->mdio_clk);
>
>       Andrew
Thanks Andrew for the comments, will update it in the next patch set.