netdev - Re: [PATCH] Revert "bus: mhi: pci-generic: configurable network interface MRU"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 13 Aug 2021 22:53:16 +0800
From:   kernel test robot <lkp@...el.com>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        kuba@...nel.org, davem@...emloft.net
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, Richard.Laing@...iedtelesis.co.nz,
        loic.poulain@...aro.org,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Subject: Re: [PATCH] Revert "bus: mhi: pci-generic: configurable network
 interface MRU"

Hi Manivannan,

I love your patch! Yet something to improve:

[auto build test ERROR on next-20210813]
[cannot apply to ipvs/master linus/master sparc-next/master v5.14-rc5 v5.14-rc4 v5.14-rc3 v5.14-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Manivannan-Sadhasivam/Revert-bus-mhi-pci-generic-configurable-network-interface-MRU/20210813-210217
base:    4b358aabb93a2c654cd1dcab1a25a589f6e2b153
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/fa503f1c2145bc97ea7da6f5ef2f7abf051d9aba
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Manivannan-Sadhasivam/Revert-bus-mhi-pci-generic-configurable-network-interface-MRU/20210813-210217
        git checkout fa503f1c2145bc97ea7da6f5ef2f7abf051d9aba
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash drivers/net/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/net/wwan/mhi_wwan_mbim.c: In function 'mhi_mbim_probe':
>> drivers/net/wwan/mhi_wwan_mbim.c:607:39: error: 'struct mhi_controller' has no member named 'mru'
     607 |         mbim->mru = mhi_dev->mhi_cntrl->mru ? mhi_dev->mhi_cntrl->mru : MHI_DEFAULT_MRU;
         |                                       ^~
   drivers/net/wwan/mhi_wwan_mbim.c:607:65: error: 'struct mhi_controller' has no member named 'mru'
     607 |         mbim->mru = mhi_dev->mhi_cntrl->mru ? mhi_dev->mhi_cntrl->mru : MHI_DEFAULT_MRU;
         |                                                                 ^~


vim +607 drivers/net/wwan/mhi_wwan_mbim.c

aa730a9905b7b0 Loic Poulain   2021-08-03  593  
aa730a9905b7b0 Loic Poulain   2021-08-03  594  static int mhi_mbim_probe(struct mhi_device *mhi_dev, const struct mhi_device_id *id)
aa730a9905b7b0 Loic Poulain   2021-08-03  595  {
aa730a9905b7b0 Loic Poulain   2021-08-03  596  	struct mhi_controller *cntrl = mhi_dev->mhi_cntrl;
aa730a9905b7b0 Loic Poulain   2021-08-03  597  	struct mhi_mbim_context *mbim;
aa730a9905b7b0 Loic Poulain   2021-08-03  598  	int err;
aa730a9905b7b0 Loic Poulain   2021-08-03  599  
aa730a9905b7b0 Loic Poulain   2021-08-03  600  	mbim = devm_kzalloc(&mhi_dev->dev, sizeof(*mbim), GFP_KERNEL);
aa730a9905b7b0 Loic Poulain   2021-08-03  601  	if (!mbim)
aa730a9905b7b0 Loic Poulain   2021-08-03  602  		return -ENOMEM;
aa730a9905b7b0 Loic Poulain   2021-08-03  603  
94c0a6fbd5cfc3 Wei Yongjun    2021-08-08  604  	spin_lock_init(&mbim->tx_lock);
aa730a9905b7b0 Loic Poulain   2021-08-03  605  	dev_set_drvdata(&mhi_dev->dev, mbim);
aa730a9905b7b0 Loic Poulain   2021-08-03  606  	mbim->mdev = mhi_dev;
aa730a9905b7b0 Loic Poulain   2021-08-03 @607  	mbim->mru = mhi_dev->mhi_cntrl->mru ? mhi_dev->mhi_cntrl->mru : MHI_DEFAULT_MRU;
aa730a9905b7b0 Loic Poulain   2021-08-03  608  
aa730a9905b7b0 Loic Poulain   2021-08-03  609  	INIT_DELAYED_WORK(&mbim->rx_refill, mhi_net_rx_refill_work);
aa730a9905b7b0 Loic Poulain   2021-08-03  610  
aa730a9905b7b0 Loic Poulain   2021-08-03  611  	/* Start MHI channels */
0ca8d3ca456153 Jakub Kicinski 2021-08-05  612  	err = mhi_prepare_for_transfer(mhi_dev, 0);
aa730a9905b7b0 Loic Poulain   2021-08-03  613  	if (err)
aa730a9905b7b0 Loic Poulain   2021-08-03  614  		return err;
aa730a9905b7b0 Loic Poulain   2021-08-03  615  
aa730a9905b7b0 Loic Poulain   2021-08-03  616  	/* Number of transfer descriptors determines size of the queue */
aa730a9905b7b0 Loic Poulain   2021-08-03  617  	mbim->rx_queue_sz = mhi_get_free_desc_count(mhi_dev, DMA_FROM_DEVICE);
aa730a9905b7b0 Loic Poulain   2021-08-03  618  
aa730a9905b7b0 Loic Poulain   2021-08-03  619  	/* Register wwan link ops with MHI controller representing WWAN instance */
aa730a9905b7b0 Loic Poulain   2021-08-03  620  	return wwan_register_ops(&cntrl->mhi_dev->dev, &mhi_mbim_wwan_ops, mbim, 0);
aa730a9905b7b0 Loic Poulain   2021-08-03  621  }
aa730a9905b7b0 Loic Poulain   2021-08-03  622  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (55437 bytes)