netdev - Re: [PATCH v2] qed: qed ll2 race condition fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210813170530.7a12984f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 13 Aug 2021 17:05:30 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Shai Malin <smalin@...vell.com>
Cc:     <netdev@...r.kernel.org>, <davem@...emloft.net>,
        <aelior@...vell.com>, <malin1024@...il.com>
Subject: Re: [PATCH v2] qed: qed ll2 race condition fixes

On Thu, 12 Aug 2021 22:53:13 +0300 Shai Malin wrote:
> Avoiding qed ll2 race condition and NULL pointer dereference as part
> of the remove and recovery flows.
> 
> Changes form V1:
> - Change (!p_rx->set_prod_addr).
> - qed_ll2.c checkpatch fixes.
> 
> Signed-off-by: Ariel Elior <aelior@...vell.com>
> Signed-off-by: Shai Malin <smalin@...vell.com>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_ll2.c | 38 +++++++++++++++++------
>  1 file changed, 29 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
> index 02a4610d9330..9a9f0c516c0c 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
> @@ -106,7 +106,7 @@ static int qed_ll2_alloc_buffer(struct qed_dev *cdev,
>  }
>  
>  static int qed_ll2_dealloc_buffer(struct qed_dev *cdev,
> -				 struct qed_ll2_buffer *buffer)
> +				  struct qed_ll2_buffer *buffer)
>  {
>  	spin_lock_bh(&cdev->ll2->lock);
>  

> @@ -670,11 +682,11 @@ static int qed_ll2_lb_rxq_handler(struct qed_hwfn *p_hwfn,
>  		p_pkt = list_first_entry(&p_rx->active_descq,
>  					 struct qed_ll2_rx_packet, list_entry);
>  
> -		if ((iscsi_ooo->ooo_opcode == TCP_EVENT_ADD_NEW_ISLE) ||
> -		    (iscsi_ooo->ooo_opcode == TCP_EVENT_ADD_ISLE_RIGHT) ||
> -		    (iscsi_ooo->ooo_opcode == TCP_EVENT_ADD_ISLE_LEFT) ||
> -		    (iscsi_ooo->ooo_opcode == TCP_EVENT_ADD_PEN) ||
> -		    (iscsi_ooo->ooo_opcode == TCP_EVENT_JOIN)) {
> +		if (iscsi_ooo->ooo_opcode == TCP_EVENT_ADD_NEW_ISLE ||
> +		    iscsi_ooo->ooo_opcode == TCP_EVENT_ADD_ISLE_RIGHT ||
> +		    iscsi_ooo->ooo_opcode == TCP_EVENT_ADD_ISLE_LEFT ||
> +		    iscsi_ooo->ooo_opcode == TCP_EVENT_ADD_PEN ||
> +		    iscsi_ooo->ooo_opcode == TCP_EVENT_JOIN) {
>  			if (!p_pkt) {
>  				DP_NOTICE(p_hwfn,
>  					  "LL2 OOO RX packet is not valid\n");

Sorry, I missed this before, please don't mix code clean up into
unrelated patches. Especially into fixes. Same goes for your other
patch (qed: Fix null-pointer dereference in qed_rdma_create_qp()).