netdev - Re: [PATCH 1/2] dt-bindings: net: add RTL8152 binding documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96f1d554-647b-fc75-8c5c-60bc20d79c80@david-bauer.net>
Date:   Sun, 15 Aug 2021 00:26:32 +0200
From:   David Bauer <mail@...id-bauer.net>
To:     Heiner Kallweit <hkallweit1@...il.com>, davem@...emloft.net,
        kuba@...nel.org, robh+dt@...nel.org, Pavel Machek <pavel@....cz>
Cc:     netdev@...r.kernel.org, devicetree@...r.kernel.org,
        "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: net: add RTL8152 binding documentation

Hi Heiner,

On 8/14/21 8:33 PM, Heiner Kallweit wrote:
> On 14.08.2021 20:11, David Bauer wrote:
>> Add binding documentation for the Realtek RTL8152 / RTL8153 USB ethernet
>> adapters.
>>
>> Signed-off-by: David Bauer <mail@...id-bauer.net>
>> ---
>>   .../bindings/net/realtek,rtl8152.yaml         | 43 +++++++++++++++++++
>>   1 file changed, 43 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/net/realtek,rtl8152.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/net/realtek,rtl8152.yaml b/Documentation/devicetree/bindings/net/realtek,rtl8152.yaml
>> new file mode 100644
>> index 000000000000..ab760000b3a6
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/net/realtek,rtl8152.yaml
>> @@ -0,0 +1,43 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/net/realtek,rtl8152.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Realtek RTL8152/RTL8153 series USB ethernet
>> +
>> +maintainers:
>> +  - David Bauer <mail@...id-bauer.net>
>> +
>> +properties:
>> +  compatible:
>> +    oneOf:
>> +      - items:
>> +          - enum:
>> +              - realtek,rtl8152
>> +              - realtek,rtl8153
>> +
>> +  reg:
>> +    description: The device number on the USB bus
>> +
>> +  realtek,led-data:
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    description: Value to be written to the LED configuration register.
>> +
> 
> +Pavel as LED subsystem maintainer
> 
> There's an ongoing discussion (with certain decisions taken already) about
> how to configure network device LEDs.

Thanks, I didn't knew about this.

Is there any place where i can read up specifics about
this topic?

Best
David

> 
>> +required:
>> +  - compatible
>> +  - reg
>> +
>> +examples:
>> +  - |
>> +    usb@100 {
>> +      reg = <0x100 0x100>;
>> +      #address-cells = <1>;
>> +      #size-cells = <0>;
>> +
>> +      usb-eth@2 {
>> +        compatible = "realtek,rtl8153";
>> +        reg = <0x2>;
>> +        realtek,led-data = <0x87>;
>> +      };
>> +    };
>>
>