netdev - Re: [RFC PATCH v3 net-next 01/10] net: dsa: ocelot: remove unnecessary pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210814110705.yf7cy7ae2u6l5hcn@skbuf>
Date:   Sat, 14 Aug 2021 14:07:05 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Colin Foster <colin.foster@...advantage.com>
Cc:     andrew@...n.ch, vivien.didelot@...il.com, f.fainelli@...il.com,
        davem@...emloft.net, kuba@...nel.org, robh+dt@...nel.org,
        claudiu.manoil@....com, alexandre.belloni@...tlin.com,
        UNGLinuxDriver@...rochip.com, hkallweit1@...il.com,
        linux@...linux.org.uk, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v3 net-next 01/10] net: dsa: ocelot: remove
 unnecessary pci_bar variables

On Fri, Aug 13, 2021 at 07:49:54PM -0700, Colin Foster wrote:
> The pci_bar variables for the switch and imdio don't make sense for the
> generic felix driver. Moving them to felix_vsc9959 to limit scope and
> simplify the felix_info struct.
> 
> Signed-off-by: Colin Foster <colin.foster@...advantage.com>
> ---

I distinctly remember giving a Reviewed-by tag for this patch in the
previous series:

https://patchwork.kernel.org/project/netdevbpf/patch/20210710192602.2186370-2-colin.foster@in-advantage.com/

It would be nice if you could carry them along from one series to the
next so we don't have to chase you.

If you use git b4 when you start working on a new version, the extra
tags in the comments are downloaded and appended automatically. That is
if you are not ok with manually copy-pasting them into your commit
message.