netdev - RE: [PATCH v2 net] net: iosm: Prevent underflow in ipc_chnl_cfg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Aug 2021 12:17:19 +0000
From:   "Kumar, M Chetan" <m.chetan.kumar@...el.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Solomon Ucko <solly.ucko@...il.com>
CC:     linuxwwan <linuxwwan@...el.com>,
        Loic Poulain <loic.poulain@...aro.org>,
        Sergey Ryazanov <ryazanov.s.a@...il.com>,
        Johannes Berg <johannes@...solutions.net>,
        "David S. Miller" <davem@...emloft.net>,
        "Jakub Kicinski" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "security@...nel.org" <security@...nel.org>
Subject: RE: [PATCH v2 net] net: iosm: Prevent underflow in ipc_chnl_cfg_get()

> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@...cle.com>
> Sent: Monday, August 16, 2021 4:44 PM
> To: Kumar, M Chetan <m.chetan.kumar@...el.com>; Solomon Ucko
> <solly.ucko@...il.com>
> Cc: linuxwwan <linuxwwan@...el.com>; Loic Poulain
> <loic.poulain@...aro.org>; Sergey Ryazanov <ryazanov.s.a@...il.com>;
> Johannes Berg <johannes@...solutions.net>; David S. Miller
> <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>;
> netdev@...r.kernel.org; security@...nel.org
> Subject: [PATCH v2 net] net: iosm: Prevent underflow in ipc_chnl_cfg_get()
> 
> The bounds check on "index" doesn't catch negative values.  Using
> ARRAY_SIZE() directly is more readable and more robust because it prevents
> negative values for "index".  Fortunately we only pass valid values to
> ipc_chnl_cfg_get() so this patch does not affect runtime.
> 
> 
> Reported-by: Solomon Ucko <solly.ucko@...il.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> v2: Remove underscore between "array" and "size".
>     Use %zu print format specifier to fix a compile warning on 32 bit.
> 
>  drivers/net/wwan/iosm/iosm_ipc_chnl_cfg.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Reviewed-by: M Chetan Kumar <m.chetan.kumar@...el.com>