netdev - Re: [PATCH net-next] net: dpaa2-mac: add support for more ethtool 10G link modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210816144752.vxliq642uipdsmdd@skbuf>
Date:   Mon, 16 Aug 2021 17:47:52 +0300
From:   Ioana Ciornei <ciorneiioana@...il.com>
To:     "Russell King (Oracle)" <linux@...linux.org.uk>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Ioana Ciornei <ioana.ciornei@....com>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next] net: dpaa2-mac: add support for more ethtool
 10G link modes

On Tue, Jul 20, 2021 at 03:11:34PM +0100, Russell King (Oracle) wrote:
> On Tue, Jul 20, 2021 at 03:51:35PM +0200, Andrew Lunn wrote:
> > On Tue, Jul 20, 2021 at 10:57:43AM +0100, Russell King wrote:
> > > Phylink documentation says:
> > >   Note that the PHY may be able to transform from one connection
> > >   technology to another, so, eg, don't clear 1000BaseX just
> > >   because the MAC is unable to BaseX mode. This is more about
> > >   clearing unsupported speeds and duplex settings. The port modes
> > >   should not be cleared; phylink_set_port_modes() will help with this.
> > > 
> > > So add the missing 10G modes.
> > 
> > Hi Russell
> > 
> > Would a phylink_set_10g(mask) helper make sense? As you say, it is
> > about the speed, not the individual modes.
> 
> Yes, good point, and that will probably help avoid this in the future.
> We can't do that for things like e.g. SGMII though, because 1000/half
> isn't universally supported.
> 
> Shall we get this patch merged anyway and then clean it up - as such
> a change will need to cover multiple drivers anyway?
> 

This didn't get merged unfortunately.

Could you please resend it? Alternatively, I can take a look into adding
that phylink_set_10g() helper if that is what's keeping it from being
merged.

Ioana