netdev - RE: [PATCH v5 intel-next 2/9] ice: move ice_container_type onto ice_ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB4835F0FDF2ABA2578B722095F5FD9@CO1PR11MB4835.namprd11.prod.outlook.com>
Date:   Mon, 16 Aug 2021 16:51:06 +0000
From:   "Creeley, Brett" <brett.creeley@...el.com>
To:     "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "bjorn@...nel.org" <bjorn@...nel.org>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Lobakin, Alexandr" <alexandr.lobakin@...el.com>,
        "joamaki@...il.com" <joamaki@...il.com>,
        "toke@...hat.com" <toke@...hat.com>
Subject: RE: [PATCH v5 intel-next 2/9] ice: move ice_container_type onto
 ice_ring_container

> -----Original Message-----
> From: Fijalkowski, Maciej <maciej.fijalkowski@...el.com>
> Sent: Saturday, August 14, 2021 7:08 AM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; bpf@...r.kernel.org; davem@...emloft.net; Nguyen, Anthony L <anthony.l.nguyen@...el.com>;
> kuba@...nel.org; bjorn@...nel.org; Karlsson, Magnus <magnus.karlsson@...el.com>; Brandeburg, Jesse
> <jesse.brandeburg@...el.com>; Lobakin, Alexandr <alexandr.lobakin@...el.com>; joamaki@...il.com; toke@...hat.com; Creeley,
> Brett <brett.creeley@...el.com>; Fijalkowski, Maciej <maciej.fijalkowski@...el.com>
> Subject: [PATCH v5 intel-next 2/9] ice: move ice_container_type onto ice_ring_container
> 
> Currently ice_container_type is scoped only for ice_ethtool.c. Next
> commit that will split the ice_ring struct onto Rx/Tx specific ring
> structs is going to also modify the type of linked list of rings that is
> within ice_ring_container. Therefore, the functions that are taking the
> ice_ring_container as an input argument will need to be aware of a ring
> type that will be looked up.
> 
> Embed ice_container_type within ice_ring_container and initialize it
> properly when allocating the q_vectors.
> 
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_base.c    |  2 ++
>  drivers/net/ethernet/intel/ice/ice_ethtool.c | 36 ++++++++------------
>  drivers/net/ethernet/intel/ice/ice_txrx.h    |  6 ++++
>  3 files changed, 23 insertions(+), 21 deletions(-)

<snip>

> +enum ice_container_type {
> +	ICE_RX_CONTAINER,
> +	ICE_TX_CONTAINER,
> +};
> +
>  struct ice_ring_container {
>  	/* head of linked-list of rings */
>  	struct ice_ring *ring;
> @@ -347,6 +352,7 @@ struct ice_ring_container {
>  	u16 itr_setting:13;
>  	u16 itr_reserved:2;
>  	u16 itr_mode:1;
> +	enum ice_container_type type;

It may not matter, but should you make sure
the size of "type" doesn't negativelly affect this
structure?

>  };
> 
>  struct ice_coalesce_stored {
> --
> 2.20.1