netdev - Re: [net-next 16/17] net/mlx5: Bridge, allow merged eswitch connectivity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56cd4ba05d5393af8a2d4490d73e34279d0bf1ac.camel@kernel.org>
Date:   Mon, 16 Aug 2021 16:23:14 -0700
From:   Saeed Mahameed <saeed@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Tariq Toukan <tariqt@...dia.com>,
        Leon Romanovsky <leonro@...dia.com>,
        Vlad Buslov <vladbu@...dia.com>, Roi Dayan <roid@...dia.com>,
        Mark Bloch <mbloch@...dia.com>
Subject: Re: [net-next 16/17] net/mlx5: Bridge, allow merged eswitch
 connectivity

On Mon, 2021-08-16 at 15:38 -0700, Jakub Kicinski wrote:
> On Mon, 16 Aug 2021 14:18:46 -0700 Saeed Mahameed wrote:
> > From: Vlad Buslov <vladbu@...dia.com>
> > 
> > Allow connectivity between representors of different eswitch
> > instances that
> > are attached to same bridge when merged_eswitch capability is
> > enabled. Add
> > ports of peer eswitch to bridge instance and mark them with
> > MLX5_ESW_BRIDGE_PORT_FLAG_PEER. Mark FDBs offloaded on peer ports
> > with
> > MLX5_ESW_BRIDGE_FLAG_PEER flag. Such FDBs can only be aged out on
> > their
> > local eswitch instance, which then sends
> > SWITCHDEV_FDB_DEL_TO_BRIDGE event.
> > Listen to the event on mlx5 bridge implementation and delete peer
> > FDBs in
> > event handler.
> > 
> > Signed-off-by: Vlad Buslov <vladbu@...dia.com>
> > Reviewed-by: Roi Dayan <roid@...dia.com>
> > Reviewed-by: Mark Bloch <mbloch@...dia.com>
> > Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
> 
> 
> drivers/net/ethernet/mellanox/mlx5/core/en/rep/bridge.c: In function
> ‘mlx5_esw_bridge_switchdev_fdb_event_work’:
> drivers/net/ethernet/mellanox/mlx5/core/en/rep/bridge.c:286:21:
> warning: variable ‘priv’ set but not used [-Wunused-but-set-variable]
>   286 |  struct mlx5e_priv *priv;
>       |                     ^~~~

Missing kconfig in our CI.
Thanks for the reprot, handled in V2.