netdev - Re: [PATCH net-next 2/2] net: Fix offloading indirect devices dependency on qdisc order creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210817075639.3cdbfd2e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 17 Aug 2021 07:56:39 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Eli Cohen <elic@...dia.com>
Cc:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net-next 2/2] net: Fix offloading indirect devices
 dependency on qdisc order creation

On Tue, 17 Aug 2021 17:30:09 +0300 Eli Cohen wrote:
> On Tue, Aug 17, 2021 at 07:00:41AM -0700, Jakub Kicinski wrote:
> > On Tue, 17 Aug 2021 16:22:17 +0300 Eli Cohen wrote:  
> > > Currently, when creating an ingress qdisc on an indirect device before
> > > the driver registered for callbacks, the driver will not have a chance
> > > to register its filter configuration callbacks.
> > > 
> > > To fix that, modify the code such that it keeps track of all the ingress
> > > qdiscs that call flow_indr_dev_setup_offload(). When a driver calls
> > > flow_indr_dev_register(),  go through the list of tracked ingress qdiscs
> > > and call the driver callback entry point so as to give it a chance to
> > > register its callback.
> > > 
> > > Reviewed-by: Jiri Pirko <jiri@...dia.com>
> > > Signed-off-by: Eli Cohen <elic@...dia.com>  
> > 
> > net/core/flow_offload.c: In function ‘existing_qdiscs_register’:
> > net/core/flow_offload.c:365:20: warning: variable ‘block’ set but not used [-Wunused-but-set-variable]
> >   365 |  struct tcf_block *block;
> >       |                    ^~~~~  
> 
> Thanks Jakub.
> Would you mind telling me how you invoked the compiler to catch this?

make W=1