netdev - Re: [PATCH v2] net: hso: do not call unregister if not registered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN6PR2201MB173238B760C0E5B72428E2CF90FE9@BN6PR2201MB1732.namprd22.prod.outlook.com>
Date:   Tue, 17 Aug 2021 15:19:57 +0000
From:   "Yavuz, Tuba" <tuba@....ufl.edu>
To:     Salvatore Bonaccorso <carnil@...ian.org>,
        Greg KH <gregkh@...uxfoundation.org>
CC:     David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "oneukum@...e.com" <oneukum@...e.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: Re: [PATCH v2] net: hso: do not call unregister if not registered

Hi Salvatore,

I think it would be best if one of the developers of the hso driver could develop a patch along the lines of David Miller's earlier suggestion.

Best,

Tuba

________________________________________
From: Salvatore Bonaccorso <salvatore.bonaccorso@...il.com> on behalf of Salvatore Bonaccorso <carnil@...ian.org>
Sent: Monday, August 16, 2021 2:52 AM
To: Greg KH
Cc: David Miller; Yavuz, Tuba; netdev@...r.kernel.org; kuba@...nel.org; oneukum@...e.com; linux-kernel@...r.kernel.org; linux-usb@...r.kernel.org
Subject: Re: [PATCH v2] net: hso: do not call unregister if not registered

[External Email]

Hi Greg, Tuba,

On Sun, Oct 04, 2020 at 09:14:33AM +0200, Greg KH wrote:
> On Sat, Oct 03, 2020 at 05:00:42PM -0700, David Miller wrote:
> > From: Greg KH <gregkh@...uxfoundation.org>
> > Date: Fri, 2 Oct 2020 13:43:23 +0200
> >
> > > @@ -2366,7 +2366,8 @@ static void hso_free_net_device(struct hso_device *hso_dev, bool bailout)
> > >
> > >   remove_net_device(hso_net->parent);
> > >
> > > - if (hso_net->net)
> > > + if (hso_net->net &&
> > > +     hso_net->net->reg_state == NETREG_REGISTERED)
> > >           unregister_netdev(hso_net->net);
> > >
> > >   /* start freeing */
> >
> > I really want to get out of the habit of drivers testing the internal
> > netdev registration state to make decisions.
> >
> > Instead, please track this internally.  You know if you registered the
> > device or not, therefore use that to control whether you try to
> > unregister it or not.
>
> Fair enough.  Tuba, do you want to fix this up in this way, or do you
> recommend that someone else do it?

Do I miss something, or did that possibly fall through the cracks?

I was checking some open issues on a downstream distro side and found
htat this thread did not got a follow-up.

Regards,
Salvatore