netdev - Re: [PATCH net-next v2 8/8] ravb: Add tx_drop_cntrs to struct ravb_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b09e2ba-4e92-6e1e-e26b-c2a3152f7fe4@omp.ru>
Date:   Tue, 17 Aug 2021 19:30:39 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Biju Das <biju.das.jz@...renesas.com>,
        Sergei Shtylyov <sergei.shtylyov@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        "Jakub Kicinski" <kuba@...nel.org>
CC:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Sergey Shtylyov <s.shtylyov@...russia.ru>,
        Adam Ford <aford173@...il.com>, Andrew Lunn <andrew@...n.ch>,
        Yuusuke Ashizuka <ashiduka@...itsu.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Biju Das <biju.das@...renesas.com>,
        "Prabhakar Mahadev Lad" <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH net-next v2 8/8] ravb: Add tx_drop_cntrs to struct
 ravb_hw_info

Hello!

On 8/17/21 6:47 PM, Biju Das wrote:

[...]
>>> The register for retrieving TX drop counters is present only on R-Car
>>> Gen3 and RZ/G2L; it is not present on R-Car Gen2.
>>>
>>> Add the tx_drop_cntrs hw feature bit to struct ravb_hw_info, to enable
>>> this feature specifically for R-Car Gen3 now and later extend it to
>> RZ/G2L.
>>>
>>> Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
>>> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
>>> ---
>>> v2:
>>>  * Incorporated Andrew and Sergei's review comments for making it
>> smaller patch
>>>    and provided detailed description.
>>> ---
>>>  drivers/net/ethernet/renesas/ravb.h      | 1 +
>>>  drivers/net/ethernet/renesas/ravb_main.c | 4 +++-
>>>  2 files changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/ethernet/renesas/ravb.h
>>> b/drivers/net/ethernet/renesas/ravb.h
>>> index 0d640dbe1eed..35fbb9f60ba8 100644
>>> --- a/drivers/net/ethernet/renesas/ravb.h
>>> +++ b/drivers/net/ethernet/renesas/ravb.h
>>> @@ -1001,6 +1001,7 @@ struct ravb_hw_info {
>>>
>>>  	/* hardware features */
>>>  	unsigned internal_delay:1;	/* RAVB has internal delays */
>>> +	unsigned tx_drop_cntrs:1;	/* RAVB has TX error counters */
>>
>>    I suggest 'tx_counters' -- this name comes from the sh_eth driver for
>> the same regs (but negated meaning). And please don't call the hardware
>> RAVB. :-)
> 
> Agreed. Will change it to 'tx_counters' on next version and comment it as
> /* AVB-DMAC has TX counters */

   The counters belong to E-MAC, not AVB-DMAC.

> Cheers,
> Biju

MBR, Sergey