netdev - Re: [PATCH v2 net-next 1/1] ptp_ocp: use bits.h macros for all masks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YRvnz01sPpHMnkqQ@smile.fi.intel.com>
Date:   Tue, 17 Aug 2021 19:46:07 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Jonathan Lemon <jonathan.lemon@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH v2 net-next 1/1] ptp_ocp: use bits.h macros for all masks

On Tue, Aug 17, 2021 at 06:48:14AM -0700, Jakub Kicinski wrote:
> On Tue, 17 Aug 2021 15:24:54 +0300 Andy Shevchenko wrote:
> > Currently we are using BIT(), but GENMASK(). Make use of the latter one
> > as well (far less error-prone, far more concise).

> GENMASK is unsigned long:

Ouch, thanks!

-- 
With Best Regards,
Andy Shevchenko