netdev - Re: [PATCH net 1/1] net/rds: dma_map_sg is entitled to merge entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30038EA9-7220-4FBC-8601-50D226244722@oracle.com>
Date:   Tue, 17 Aug 2021 17:07:19 +0000
From:   Santosh Shilimkar <santosh.shilimkar@...cle.com>
To:     Gerd Rausch <gerd.rausch@...cle.com>
CC:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "rds-devel@....oracle.com" <rds-devel@....oracle.com>
Subject: Re: [PATCH net 1/1] net/rds: dma_map_sg is entitled to merge entries



> On Aug 17, 2021, at 10:04 AM, Gerd Rausch <gerd.rausch@...cle.com> wrote:
> 
> Function "dma_map_sg" is entitled to merge adjacent entries
> and return a value smaller than what was passed as "nents".
> 
> Subsequently "ib_map_mr_sg" needs to work with this value ("sg_dma_len")
> rather than the original "nents" parameter ("sg_len").
> 
> This old RDS bug was exposed and reliably causes kernel panics
> (using RDMA operations "rds-stress -D") on x86_64 starting with:
> commit c588072bba6b ("iommu/vt-d: Convert intel iommu driver to the iommu ops")
> 
> Simply put: Linux 5.11 and later.
> 
> Signed-off-by: Gerd Rausch <gerd.rausch@...cle.com>
> ---
> net/rds/ib_frmr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Looks good to me Gerd. Thanks !!

Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.com>