netdev - Re: [PATCH net] net: dsa: sja1105: fix use-after-free after calling of_find_compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27140e44-1dfc-4166-9f57-1bbb1ca1dba9@bang-olufsen.dk>
Date:   Tue, 17 Aug 2021 22:19:24 +0000
From:   Alvin Šipraga <ALSI@...g-olufsen.dk>
To:     Andrew Lunn <andrew@...n.ch>
CC:     Vladimir Oltean <vladimir.oltean@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Frank Rowand <frowand.list@...il.com>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH net] net: dsa: sja1105: fix use-after-free after calling
 of_find_compatible_node, or worse

Hi Andrew,

On 8/18/21 12:05 AM, Andrew Lunn wrote:
>> Do these integrated NXP PHYs use a specific PHY driver, or do they just
>> use the Generic PHY driver? If the former is the case, do you experience
>> that the PHY driver fails to get probed during mdiobus registration if
>> the kernel uses fw_devlink=on?
> 
> The Marvell mv88e6xxx driver registers upto two MDIO busses, and the
> PHYs on those busses make use of the marvell PHY driver. I've not
> tested specifically with fw_devlink=on, but in general, the Marvell
> PHY driver does get bound to these devices.

Thanks for your reply. I should add that with fw_devlink=permissive, the 
PHY driver gets probed just fine. It's only since v5.13 that 
fw_devlink=on has been the default[1], so it may be something new to 
check. But if you think it's working for other drivers then that means I 
will have to look into further on my end.

Kind regards,
Alvin

[1] ea718c699055 ("Revert "Revert "driver core: Set fw_devlink=on by 
default""")
 
https://lore.kernel.org/lkml/20210302211133.2244281-4-saravanak@google.com/

> 
>      Andrew
>