netdev - Re: [PATCH net-next 2/4] ethtool: extend coalesce setting uAPI with CQE mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c03f3079-ec46-6bfc-5d14-1eaa7e1ef667@huawei.com>
Date:   Wed, 18 Aug 2021 09:57:43 +0800
From:   moyufeng <moyufeng@...wei.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <shenjian15@...wei.com>, <lipeng321@...wei.com>,
        <yisen.zhuang@...wei.com>, <linyunsheng@...wei.com>,
        <huangguangbin2@...wei.com>, <chenhao288@...ilicon.com>,
        <salil.mehta@...wei.com>, <linuxarm@...wei.com>,
        <linuxarm@...neuler.org>, <dledford@...hat.com>, <jgg@...pe.ca>,
        <netanel@...zon.com>, <akiyano@...zon.com>,
        <thomas.lendacky@....com>, <irusskikh@...vell.com>,
        <michael.chan@...adcom.com>, <edwin.peer@...adcom.com>,
        <rohitm@...lsio.com>, <jacob.e.keller@...el.com>,
        <ioana.ciornei@....com>, <vladimir.oltean@....com>,
        <sgoutham@...vell.com>, <sbhatta@...vell.com>, <saeedm@...dia.com>,
        <ecree.xilinx@...il.com>, <grygorii.strashko@...com>,
        <merez@...eaurora.org>, <kvalo@...eaurora.org>,
        <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH net-next 2/4] ethtool: extend coalesce setting uAPI with
 CQE mode



On 2021/8/17 21:39, Jakub Kicinski wrote:
> On Tue, 17 Aug 2021 10:36:05 +0800 Yufeng Mo wrote:
>> In order to support more coalesce parameters through netlink,
>> add an new structure kernel_ethtool_coalesce, and keep
>> struct ethtool_coalesce as the base(legacy) part, then the
>> new parameter can be added into struct kernel_ethtool_coalesce.
>>
>> Also add new extack parameter for .set_coalesce and .get_coalesce
>> then some extra info can return to user with the netlink API.
>>
>> Signed-off-by: Yufeng Mo <moyufeng@...wei.com>
>> Signed-off-by: Huazhong Tan <tanhuazhong@...wei.com>
> 
> This and the following patches don't build, please make sure
> allmodconfig builds correctly. Here's an example failure, but
> IDK if there isn't more:
> 
> drivers/net/ethernet/ti/davinci_emac.c: In function ‘emac_dev_open’:
> drivers/net/ethernet/ti/davinci_emac.c:1469:3: error: too few arguments to function ‘emac_set_coalesce’
>  1469 |   emac_set_coalesce(ndev, &coal);
>       |   ^~~~~~~~~~~~~~~~~
> .
> 
Sorry, I'll check allmodconfig again and make sure all builds correctly.