netdev - Re: [PATCH] ovs: clear skb->tstamp in forwarding path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <401464ef-2238-ebe0-c661-714403083317@gmail.com>
Date:   Wed, 18 Aug 2021 11:32:03 +0200
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     fankaixi.li@...edance.com, dev@...nvswitch.org,
        netdev@...r.kernel.org
Cc:     xiexiaohui <xiexiaohui.xxh@...edance.com>,
        Cong Wang <cong.wang@...edance.com>
Subject: Re: [PATCH] ovs: clear skb->tstamp in forwarding path



On 8/18/21 4:22 AM, fankaixi.li@...edance.com wrote:
> From: kaixi.fan <fankaixi.li@...edance.com>
> 
> fq qdisc requires tstamp to be cleared in the forwarding path. Now ovs
> doesn't clear skb->tstamp. We encountered a problem with linux
> version 5.4.56 and ovs version 2.14.1, and packets failed to
> dequeue from qdisc when fq qdisc was attached to ovs port.
> 

Fixes: fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC")

This is more precise than " version 5.4.56 and ovs version ..."

Thanks.

> Signed-off-by: kaixi.fan <fankaixi.li@...edance.com>
> Signed-off-by: xiexiaohui <xiexiaohui.xxh@...edance.com>
> Reviewed-by: Cong Wang <cong.wang@...edance.com>
> ---
>  net/openvswitch/vport.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c
> index 88deb5b41429..cf2ce5812489 100644
> --- a/net/openvswitch/vport.c
> +++ b/net/openvswitch/vport.c
> @@ -507,6 +507,7 @@ void ovs_vport_send(struct vport *vport, struct sk_buff *skb, u8 mac_proto)
>  	}
>  
>  	skb->dev = vport->dev;
> +	skb->tstamp = 0;
>  	vport->ops->send(skb);
>  	return;
>  
>