netdev - Re: [PATCH] net/mlx4: Use ARRAY_SIZE to get an array's size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5612b0fa-5623-f7d9-6dbe-e2f7165611a6@gmail.com>
Date:   Wed, 18 Aug 2021 15:28:19 +0300
From:   Tariq Toukan <ttoukan.linux@...il.com>
To:     Joe Perches <joe@...ches.com>, Jason Wang <wangborong@...rlc.com>,
        kuba@...nel.org
Cc:     davem@...emloft.net, tariqt@...dia.com, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/mlx4: Use ARRAY_SIZE to get an array's size



On 8/18/2021 3:39 AM, Joe Perches wrote:
> On Tue, 2021-08-17 at 20:11 +0800, Jason Wang wrote:
>> The ARRAY_SIZE macro is defined to get an array's size which is
>> more compact and more formal in linux source. Thus, we can replace
>> the long sizeof(arr)/sizeof(arr[0]) with the compact ARRAY_SIZE.
> []
>> diff --git a/drivers/net/ethernet/mellanox/mlx4/qp.c b/drivers/net/ethernet/mellanox/mlx4/qp.c
> []
>> @@ -739,7 +739,7 @@ static void mlx4_cleanup_qp_zones(struct mlx4_dev *dev)
>>   		int i;
>>   
>>
>>   		for (i = 0;
>> -		     i < sizeof(qp_table->zones_uids)/sizeof(qp_table->zones_uids[0]);
>> +		     i < ARRAY_SIZE(qp_table->zones_uids);
>>   		     i++) {
> 
> trivia:  could now be a single line
> 
> 		for (i = 0; i < ARRAY_SIZE(qp_table->zones_uids); i++) {
> 
> 

I'm fine with both suggestions.
Reviewed-by: Tariq Toukan <tariqt@...dia.com>

Thanks for your patch.
Tariq